Skip to content

fix(e2e): parse E2E_WORKERS as number for playwright config#8133

Merged
jacekradko merged 1 commit intomainfrom
jacek/fix-e2e-workers-parse
Mar 20, 2026
Merged

fix(e2e): parse E2E_WORKERS as number for playwright config#8133
jacekradko merged 1 commit intomainfrom
jacek/fix-e2e-workers-parse

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 20, 2026 •
edited by coderabbitai bot
Loading

Summary

Test plan

  • E2E_WORKERS=2 node -e "console.log(Number('2'))" → 2 (number)
  • Without E2E_WORKERS, falls back to percentage strings as before

Summary by CodeRabbit

  • Chores
    • Improved E2E test worker configuration to properly process environment variable values, ensuring correct type handling during test execution.

@jacekradko
fix(e2e): parse E2E_WORKERS as number for playwright config
7d26b3b 
Playwright requires workers to be a number or percentage string.
The env var comes in as string '2' which isn't accepted.
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

⚠️ No Changeset found

Latest commit: 7d26b3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 20, 2026 2:23am

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8133

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8133

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8133

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8133

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8133

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8133

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8133

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8133

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8133

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8133

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8133

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8133

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8133

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8133

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8133

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8133

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8133

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8133

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8133

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8133

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8133

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8133

commit: 7d26b3b

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: c31bdbfe-356d-4cad-b37b-3cbce08b6567

📥 Commits

Reviewing files that changed from the base of the PR and between 21ec3d6 and 7d26b3b.

📒 Files selected for processing (1)
  • integration/playwright.config.ts
📝 Walkthrough

Walkthrough

Updated Playwright worker configuration to handle the process.env.E2E_WORKERS environment variable by coercing it from a string to a Number type when set. The fallback behavior remains unchanged, applying '50%' in CI environments and '70%' otherwise when the environment variable is not defined. This is a minimal change affecting a single line of code.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: parsing E2E_WORKERS as a number for the Playwright configuration to fix a type validation error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko jacekradko merged commit 21c7c55 into main Mar 20, 2026
41 of 44 checks passed
@jacekradko jacekradko deleted the jacek/fix-e2e-workers-parse branch March 20, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsoriano wobsoriano wobsoriano approved these changes

Assignees

No one assigned

Labels

integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko @wobsoriano